Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix width of code samples #3654

Merged
merged 2 commits into from
Sep 14, 2023
Merged

Fix width of code samples #3654

merged 2 commits into from
Sep 14, 2023

Conversation

bernardnormier
Copy link
Member

This PR fix the width of the code samples in README.md, so that they dispatch properly (without scroll bar) on nuget.org.

I think the max width is 99 or 100 columns.

Fixes #3653.

externl
externl reviewed Sep 14, 2023
View reviewed changes
Copy link
Member

@externl externl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's already obvious that the code is C#. The rest of the changes are good.

externl
externl approved these changes Sep 14, 2023
View reviewed changes
Copy link
Member

@externl externl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@bernardnormier bernardnormier merged commit 89a7a84 into icerpc:main Sep 14, 2023
2 checks passed
@bernardnormier bernardnormier deleted the fix3653 branch October 19, 2023 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@externl externl externl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update sample code in READMEs
2 participants
@bernardnormier @externl